* [PATCH] t/git-http-backend: explain purpose of test
@ 2019-06-15 17:38 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2019-06-15 17:38 UTC (permalink / raw)
To: meta
I found myself tempted to switch to HTTP::Tiny, here, since
it's distributed with Perl since 5.14, unlike Net::HTTP
(which AFAIK was never a part of Perl proper).
But we really want to use Net::HTTP, here, since it's
lower-level and allows us to trigger server-side buffering
by not reading the entity body.
---
t/git-http-backend.t | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/t/git-http-backend.t b/t/git-http-backend.t
index 5ac0a4a..fc2d546 100644
--- a/t/git-http-backend.t
+++ b/t/git-http-backend.t
@@ -1,5 +1,8 @@
# Copyright (C) 2016-2018 all contributors <meta@public-inbox.org>
# License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt>
+#
+# Ensure buffering behavior in -httpd doesn't cause runaway memory use
+# or data corruption
use strict;
use warnings;
use Test::More;
@@ -77,6 +80,8 @@ SKIP: {
my ($code, $mess, %h) = $http->read_response_headers;
is(200, $code, 'got 200 success for pack');
is($max, $h{'Content-Length'}, 'got expected Content-Length for pack');
+
+ # no $http->read_entity_body, here, since we want to force buffering
foreach my $i (1..3) {
sleep 1;
my $diff = $get_maxrss->() - $mem_a;
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-15 17:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-15 17:38 [PATCH] t/git-http-backend: explain purpose of test Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).