From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] searchidx: fix obvious typo
Date: Mon, 27 May 2019 18:45:44 +0000 [thread overview]
Message-ID: <20190527184545.536-3-e@80x24.org> (raw)
In-Reply-To: <20190527184545.536-1-e@80x24.org>
We can't pass an empty string to `git merge-base --is-ancestor'
AFAIK, this did NOT present issues in the current test suite.
---
lib/PublicInbox/SearchIdx.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 9c29106..b963805 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -694,7 +694,7 @@ sub _last_x_commit {
$lx = $lm;
}
# Use last_commit from msgmap if it is older or unset
- if (!$lm || ($lx && $lx && is_ancestor($self->{git}, $lm, $lx))) {
+ if (!$lm || ($lx && $lm && is_ancestor($self->{git}, $lm, $lx))) {
$lx = $lm;
}
$lx;
--
EW
next prev parent reply other threads:[~2019-05-27 18:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-25 19:57 --reindex buggy wrt NNTP numbers, fixes coming Eric Wong
2019-05-27 18:45 ` [PATCH 0/3] fix --reindex skipping NNTP article numbers Eric Wong
2019-05-27 18:45 ` [PATCH 1/3] t/v1reindex.t: fix typo in setting `indexlevel' Eric Wong
2019-05-27 18:45 ` Eric Wong [this message]
2019-05-27 18:45 ` [PATCH 3/3] v2: fix reindex skipping NNTP article numbers Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190527184545.536-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).