From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id E294E1F4B9 for ; Tue, 14 May 2019 03:32:03 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 3/4] t/nntp.t: skip if Data::Dumper is missing Date: Tue, 14 May 2019 03:32:02 +0000 Message-Id: <20190514033203.6160-4-e@80x24.org> In-Reply-To: <20190514033203.6160-1-e@80x24.org> References: <20190514033203.6160-1-e@80x24.org> List-Id: We can revisit this, later; but Data::Dumper requires a separate package for CentOS-7 users, at least. --- t/nntp.t | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/t/nntp.t b/t/nntp.t index 47b1442..c4b9737 100644 --- a/t/nntp.t +++ b/t/nntp.t @@ -3,9 +3,8 @@ use strict; use warnings; use Test::More; -use Data::Dumper; -foreach my $mod (qw(DBD::SQLite Search::Xapian)) { +foreach my $mod (qw(DBD::SQLite Search::Xapian Data::Dumper)) { eval "require $mod"; plan skip_all => "$mod missing for nntp.t" if $@; } @@ -15,7 +14,7 @@ use_ok 'PublicInbox::Inbox'; { sub quote_str { - my (undef, $s) = split(/ = /, Dumper($_[0]), 2); + my (undef, $s) = split(/ = /, Data::Dumper::Dumper($_[0]), 2); $s =~ s/;\n//; $s; } -- EW