From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/4] t/nntp.t: skip if Data::Dumper is missing
Date: Tue, 14 May 2019 03:32:02 +0000 [thread overview]
Message-ID: <20190514033203.6160-4-e@80x24.org> (raw)
In-Reply-To: <20190514033203.6160-1-e@80x24.org>
We can revisit this, later; but Data::Dumper requires a separate
package for CentOS-7 users, at least.
---
t/nntp.t | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/t/nntp.t b/t/nntp.t
index 47b1442..c4b9737 100644
--- a/t/nntp.t
+++ b/t/nntp.t
@@ -3,9 +3,8 @@
use strict;
use warnings;
use Test::More;
-use Data::Dumper;
-foreach my $mod (qw(DBD::SQLite Search::Xapian)) {
+foreach my $mod (qw(DBD::SQLite Search::Xapian Data::Dumper)) {
eval "require $mod";
plan skip_all => "$mod missing for nntp.t" if $@;
}
@@ -15,7 +14,7 @@ use_ok 'PublicInbox::Inbox';
{
sub quote_str {
- my (undef, $s) = split(/ = /, Dumper($_[0]), 2);
+ my (undef, $s) = split(/ = /, Data::Dumper::Dumper($_[0]), 2);
$s =~ s/;\n//;
$s;
}
--
EW
next prev parent reply other threads:[~2019-05-14 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 3:31 [PATCH 0/4] test loading cleanups Eric Wong
2019-05-14 3:32 ` [PATCH 1/4] tests: remove unnecessary loading of ::DS and Socket Eric Wong
2019-05-14 3:32 ` [PATCH 2/4] t/config.t: remove Data::Dumper dependency Eric Wong
2019-05-14 3:32 ` Eric Wong [this message]
2019-05-14 3:32 ` [PATCH 4/4] tests: get rid of unnecessary Cwd module use Eric Wong
2019-05-14 4:02 ` [PATCH v2 " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514033203.6160-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).