From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/4] t/config.t: remove Data::Dumper dependency
Date: Tue, 14 May 2019 03:32:01 +0000 [thread overview]
Message-ID: <20190514033203.6160-3-e@80x24.org> (raw)
In-Reply-To: <20190514033203.6160-1-e@80x24.org>
CentOS-7 needs the perl-Data-Dumper package, and the
test is small enough to roll our own escaping, here.
---
t/config.t | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/t/config.t b/t/config.t
index ad738bd..f0c274b 100644
--- a/t/config.t
+++ b/t/config.t
@@ -127,10 +127,13 @@ my @invalid = (
);
-require Data::Dumper;
+my %X = ("\0" => '\\0', "\b" => '\\b', "\f" => '\\f', "'" => "\\'");
+my $xre = join('|', keys %X);
+
for my $s (@invalid) {
- my $d = Data::Dumper->new([$s])->Terse(1)->Indent(0)->Dump;
- ok(!PublicInbox::Config::valid_inbox_name($s), "$d name rejected");
+ my $d = $s;
+ $d =~ s/($xre)/$X{$1}/g;
+ ok(!PublicInbox::Config::valid_inbox_name($s), "`$d' name rejected");
}
# obviously-valid examples
@@ -146,8 +149,7 @@ my @valid = qw(a a@example a@example.com);
# '!', '$', '=', '+'
push @valid, qw[bang! ca$h less< more> 1% (parens) &more eql= +plus], '#hash';
for my $s (@valid) {
- my $d = Data::Dumper->new([$s])->Terse(1)->Indent(0)->Dump;
- ok(PublicInbox::Config::valid_inbox_name($s), "$d name accepted");
+ ok(PublicInbox::Config::valid_inbox_name($s), "`$s' name accepted");
}
{
--
EW
next prev parent reply other threads:[~2019-05-14 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 3:31 [PATCH 0/4] test loading cleanups Eric Wong
2019-05-14 3:32 ` [PATCH 1/4] tests: remove unnecessary loading of ::DS and Socket Eric Wong
2019-05-14 3:32 ` Eric Wong [this message]
2019-05-14 3:32 ` [PATCH 3/4] t/nntp.t: skip if Data::Dumper is missing Eric Wong
2019-05-14 3:32 ` [PATCH 4/4] tests: get rid of unnecessary Cwd module use Eric Wong
2019-05-14 4:02 ` [PATCH v2 " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514033203.6160-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).