[PATCH] httpd: get rid of Deflater warning

[PATCH] httpd: get rid of Deflater warning

[Eric Wong]

Deflating responses may be done by the reverse proxy (e.g. varnish
or nginx), so the warning for it could be invalid.
---
 examples/public-inbox.psgi | 2 --
 script/public-inbox-httpd  | 2 --
 2 files changed, 4 deletions(-)

diff --git a/examples/public-inbox.psgi b/examples/public-inbox.psgi
index 8886d7f..0b8500d 100644
--- a/examples/public-inbox.psgi
+++ b/examples/public-inbox.psgi
@@ -25,8 +25,6 @@ builder {
 				application/atom+xml
 				)]
 	};
-	$@ and warn
-"Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
 
 	# Enable to ensure redirects and Atom feed URLs are generated
 	# properly when running behind a reverse proxy server which
diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index 47e38ec..56551ed 100755
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -32,8 +32,6 @@ my $refresh = sub {
 						application/atom+xml
 						)]
 			};
-			$@ and warn
-"Plack::Middleware::Deflater missing, bandwidth will be wasted\n";
 
 			eval { enable 'ReverseProxy' };
 			$@ and warn
-- 
EW

default PSGI middlewares (was: httpd: get rid of Deflater warning)

[Eric Wong]

Now, the ReverseProxy middleware may be invalid (or become less
valid) in the future as well: TLS may come to NNTP and we might
as well support HTTPS natively while we're at it.

I can't drop middlewares by default since it would break
existing installations which don't rely on a .psgi config;
but there can be options to disable it... (not that I'm a
fan of adding more options).

Keeping ReverseProxy in the default middleware stack along with
the existing warning would probably be the right thing to do.
Worst case somebody malicious could do is change logging of
IP addresses.  Maybe the warning could be silenced if listening
on 0.0.0.0:{443,80}