From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/4] DS: workaround IO::Kqueue EINTR (mis-)handling
Date: Sun, 5 May 2019 04:56:14 +0000 [thread overview]
Message-ID: <20190505045614.GA7031@ailurophile> (raw)
In-Reply-To: <20190505005219.31772-2-e@80x24.org>
IO::Kqueue seems unmaintained, so workaround a long-standing
bug where it falls over on signals:
https://rt.cpan.org/Ticket/Display.html?id=116615
---
TODO | 4 ----
lib/PublicInbox/DS.pm | 10 +++++++++-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/TODO b/TODO
index ac255b8..d947b0f 100644
--- a/TODO
+++ b/TODO
@@ -52,10 +52,6 @@ all need to be considered for everything we introduce)
cf. https://public-inbox.org/git/20160814012706.GA18784@starla/
-* portability to FreeBSD (and other Free Software *BSDs)
- ugh... https://rt.cpan.org/Ticket/Display.html?id=116615
- (IO::KQueue is broken with Danga::Socket / PublicInbox::DS)
-
* improve documentation
* linkify thread skeletons better
diff --git a/lib/PublicInbox/DS.pm b/lib/PublicInbox/DS.pm
index 7bd5d42..ea09fc9 100644
--- a/lib/PublicInbox/DS.pm
+++ b/lib/PublicInbox/DS.pm
@@ -428,7 +428,15 @@ sub KQueueEventLoop {
while (1) {
my $timeout = RunTimers();
- my @ret = $KQueue->kevent($timeout);
+ my @ret = eval { $KQueue->kevent($timeout) };
+ if (my $err = $@) {
+ # workaround https://rt.cpan.org/Ticket/Display.html?id=116615
+ if ($err =~ /Interrupted system call/) {
+ @ret = ();
+ } else {
+ die $err;
+ }
+ }
foreach my $kev (@ret) {
my ($fd, $filter, $flags, $fflags) = @$kev;
--
next prev parent reply other threads:[~2019-05-05 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 0:52 [PATCH 0/4] bundle Danga::Socket and Sys::Syscall Eric Wong
2019-05-05 0:52 ` [PATCH 1/4] " Eric Wong
2019-05-05 4:56 ` Eric Wong [this message]
2019-05-08 9:07 ` [PATCH 6/4] DS: handle EINTR in IO::Poll path, too Eric Wong
2019-05-05 0:52 ` [PATCH 2/4] listener: use EPOLLEXCLUSIVE for listen sockets Eric Wong
2019-05-05 0:52 ` [PATCH 3/4] DS: remove unused fields and functions Eric Wong
2019-05-05 0:52 ` [PATCH 4/4] DS: drop profiling support Eric Wong
2019-05-08 19:18 ` [PATCH 0/4] Danga::Socket bundling cleanups Eric Wong
2019-05-08 19:18 ` [PATCH 1/4] build: do not manify DS and Syscall pods Eric Wong
2019-05-08 19:18 ` [PATCH 2/4] syscall: drop readahead wrapper Eric Wong
2019-05-08 19:18 ` [PATCH 3/4] DS: drop unused "_undef" sub Eric Wong
2019-05-08 19:18 ` [PATCH 4/4] DS: epoll: fix misordered EPOLL_CTL_DEL call Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190505045614.GA7031@ailurophile \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).