From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: show "(no subject)" consistently in HTML
Date: Thu, 18 Apr 2019 23:35:26 +0000 [thread overview]
Message-ID: <20190418233526.12114-1-e@80x24.org> (raw)
Empty subjects ("") and undefined Subjects: are now both
displayed as "(no subject)" for now.
---
lib/PublicInbox/SearchView.pm | 1 +
lib/PublicInbox/View.pm | 3 +++
2 files changed, 4 insertions(+)
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 7ef6b07..3b3afde 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -120,6 +120,7 @@ sub mset_summary {
}
my $date = PublicInbox::View::fmt_ts($smsg->ds);
my $mid = PublicInbox::Hval->new_msgid($smsg->mid)->{href};
+ $s = '(no subject)' if $s eq '';
$$res .= qq{$rank. <b><a\nhref="$mid/">}.
$s . "</a></b>\n";
$$res .= "$pfx - by $f @ $date UTC [$pct%]\n\n";
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index f94daaf..62bdf0a 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -213,6 +213,7 @@ sub index_entry {
my $irt;
my $obfs_ibx = $ctx->{-obfs_ibx};
+ $subj = '(no subject)' if $subj eq '';
my $rv = "<a\nhref=#e$id\nid=m$id>*</a> ";
$subj = '<b>'.ascii_html($subj).'</b>';
obfuscate_addrs($obfs_ibx, $subj) if $obfs_ibx;
@@ -729,6 +730,7 @@ sub thread_skel {
my $subj = $hdr->header('Subject');
defined $subj or $subj = '';
+ $subj = '(no subject)' if $subj eq '';
$ctx->{prev_subj} = [ split(/ /, $srch->subject_normalized($subj)) ];
$ctx->{cur} = $mid;
$ctx->{prev_attr} = '';
@@ -1039,6 +1041,7 @@ sub acc_topic {
if ($x) {
$subj = $x->subject;
$subj = $srch->subject_normalized($subj);
+ $subj = '(no subject)' if $subj eq '';
$ds = $x->ds;
if ($level == 0) {
$topic = [ $ds, 1, { $subj => $mid }, $subj ];
--
EW
reply other threads:[~2019-04-18 23:35 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190418233526.12114-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).