From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH v2] inbox: add `modified' sub
Date: Wed, 17 Apr 2019 19:35:06 +0000 [thread overview]
Message-ID: <20190417193506.6gradvjye5jvxeu5@dcvr> (raw)
In-Reply-To: <20190417114358.ab2hsmzo7eeehghs@dcvr>
> but mtime may be worth considering over ctime, too...
> (somebody could be using atomic-rsync on the SQLite and Xapian
> stuff because indexing is slow)
-------8<----------
Subject: [PATCH] inbox: add `modified' sub
For inboxes with SQLite enabled (all v2, and probably most v1);
stat-ing the msgmap.sqlite3 file is a much faster way of telling
when an inbox is modified compared to scanning git branches.
v2: use mtime instead of ctime for users who use generic tools
to copy SQLite DBs.
---
lib/PublicInbox/Inbox.pm | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index cde4625..c004f25 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -333,4 +333,20 @@ sub recent {
search($self)->{over_ro}->recent($opts, $after, $before);
}
+sub modified {
+ my ($self) = @_;
+ my $dir = $self->{mainrepo};
+ my @st;
+ if ($self->{version} >= 2) {
+ @st = stat("$dir/msgmap.sqlite3")
+ } elsif (-f "$dir/public-inbox/msgmap.sqlite3") { # v1
+ @st = stat(_);
+ } else { # v1 repos did not need sqlite3
+ return git($self)->modified;
+ }
+ # we favor 9/mtime over ctime since it should be possible to
+ # use generic tools such as atomic-rsync to copy SQLite DBs
+ @st ? $st[9] : time;
+}
+
1;
--
EW
next prev parent reply other threads:[~2019-04-17 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 11:43 [RFC] inbox: add `modified' sub Eric Wong
2019-04-17 19:35 ` Eric Wong [this message]
2019-04-18 0:58 ` [PATCH v3] " Eric Wong
2019-04-18 8:07 ` [PATCH v4] " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190417193506.6gradvjye5jvxeu5@dcvr \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).