From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/2] import: prefix 'inbox' with '-' to denote Inbox ref
Date: Tue, 16 Apr 2019 01:10:10 +0000 [thread overview]
Message-ID: <20190416011010.19020-3-e@80x24.org> (raw)
In-Reply-To: <20190416011010.19020-1-e@80x24.org>
This is for consistency with other fields which follow
this pattern w.r.t. field-naming when referring to internal
fields.
---
lib/PublicInbox/Import.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index fc4e72d..c775575 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -30,7 +30,7 @@ sub new {
ident => "$name <$email>",
mark => 1,
ref => $ref,
- inbox => $ibx,
+ -inbox => $ibx,
path_type => '2/38', # or 'v2'
lock_path => "$git->{git_dir}/ssoma.lock", # v2 changes this
bytes_added => 0,
@@ -178,7 +178,7 @@ sub _update_git_info ($$) {
run_die([@cmd, 'update-server-info'], undef);
($self->{path_type} eq '2/38') and eval {
require PublicInbox::SearchIdx;
- my $ibx = $self->{inbox} || $git_dir;
+ my $ibx = $self->{-inbox} || $git_dir;
my $s = PublicInbox::SearchIdx->new($ibx);
$s->index_sync({ ref => $self->{ref} });
};
--
EW
prev parent reply other threads:[~2019-04-16 1:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 1:10 [PATCH 0/2] naming consistency cleanups Eric Wong
2019-04-16 1:10 ` [PATCH 1/2] cleanup: use '$ibx' consistently when referring to Inbox refs Eric Wong
2019-04-16 1:10 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190416011010.19020-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).