unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: meta@public-inbox.org
Subject: Re: Threading in git repo?
Date: Thu, 14 Mar 2019 07:44:47 +0000	[thread overview]
Message-ID: <20190314074447.GA8156@dcvr> (raw)
In-Reply-To: <20190313230707.GB210027@google.com>

Bjorn Helgaas <helgaas@kernel.org> wrote:
> Hi Eric,
> 
> As far as I can tell, pi git repos have no branching: each new message
> is added as a child commit of the most recent message, even if it is a
> response to an older message.  Have you considered making the new
> message a child of the message it is responding to?

Correct, there is no branching.  Doing threading in git does not
work because of out-of-order message delivery (which is common
in SMTP).  public-inbox-index scanning (along with notmuch and
mairix) are all resilient to out-of-order message delivery when
doing threading.

> I'm fiddling with making neomutt read a pi git repo.  Currently I only
> read the git log info (not the commit bodies).  It's pretty fast to
> read the author, date, and subject (since you conveniently stash them
> in the commit metadata), but since I'm not reading the mail headers,
> neomutt can't do all its threading magic.

neomutt could read the over.sqlite3 database...
However, I can't guarantee it's stability, either (since it's
in the "xap$VER" directory where $VER is 15, now).

Perhaps improving NNTP support in neomutt is the best way to go?

public-inbox-nntpd has room for improvement, too (see TODO)

> It seems like working out the threading could be done once at the time
> the message is added to the git repo, and threads could appear as
> branches in the repo.

Not really.  It'd still have to support "ghost" messages to
account for out-of-order message delivery; and the threading
logic can be improved and tweaked:

  https://public-inbox.org/meta/20190129075644.3917-1-e@80x24.org/

If the git commit messages all had key headers
(Message-ID/From/To/Cc/References/In-Reply-To/Subject), then
yes; then a SQLite/Xapian-agnostic client could be taught to
read and do threading based on that; with fewer git ODB
accesses.  I don't think it's worth introducing at this
time, though.

NNTP seems the best and least-fragile way forward.

  reply	other threads:[~2019-03-14  7:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 23:07 Threading in git repo? Bjorn Helgaas
2019-03-14  7:44 ` Eric Wong [this message]
2019-03-18 21:38   ` Bjorn Helgaas
2019-03-18 23:04     ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190314074447.GA8156@dcvr \
    --to=e@80x24.org \
    --cc=helgaas@kernel.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).