From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] http: cleanup partial-write handling on readonly values
Date: Wed, 6 Feb 2019 10:33:21 +0000 [thread overview]
Message-ID: <20190206103321.18006-1-e@80x24.org> (raw)
Don't bother assigning to $_[1]; just let Danga::Socket
do its thing since $_[1] should be out-of-scope soon.
---
lib/PublicInbox/HTTP.pm | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index bc10814..9657b31 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -318,11 +318,9 @@ sub more ($$) {
if (defined $n) {
my $nlen = length($_[1]) - $n;
return 1 if $nlen == 0; # all done!
- eval { $_[1] = substr($_[1], $n, $nlen) };
- if ($@) { # modification of read-only value:
- return $self->write(substr($_[1], $n, $nlen));
- }
- # fall through to normal write:
+
+ # Danga::Socket::write queues the unwritten substring:
+ return $self->write(substr($_[1], $n, $nlen));
}
}
$self->write($_[1]);
--
EW
reply other threads:[~2019-02-06 10:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190206103321.18006-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).