From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9C5B6211B5 for ; Sun, 27 Jan 2019 11:48:17 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 1/4] wwwhighlight: read_in_full returns undef on errors Date: Sun, 27 Jan 2019 11:48:14 +0000 Message-Id: <20190127114817.14486-2-e@80x24.org> In-Reply-To: <20190127114817.14486-1-e@80x24.org> References: <20190127114817.14486-1-e@80x24.org> List-Id: The return value of "print" is not undef for Perl IO::Handle. --- lib/PublicInbox/WwwHighlight.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/WwwHighlight.pm b/lib/PublicInbox/WwwHighlight.pm index 3d6ca03..09fc48a 100644 --- a/lib/PublicInbox/WwwHighlight.pm +++ b/lib/PublicInbox/WwwHighlight.pm @@ -52,6 +52,7 @@ sub read_in_full ($) { $off += $r; } $env->{'psgi.errors'}->print("input read error: $!\n"); + undef; } # entry point for PSGI -- EW