From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 04/14] qspawn|httpd/async: improve and fix out-of-date comments
Date: Sun, 27 Jan 2019 04:03:31 +0000 [thread overview]
Message-ID: <20190127040341.26107-5-e@80x24.org> (raw)
In-Reply-To: <20190127040341.26107-1-e@80x24.org>
---
lib/PublicInbox/HTTPD/Async.pm | 1 +
lib/PublicInbox/Qspawn.pm | 4 +---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm
index a8488b6..a9a9573 100644
--- a/lib/PublicInbox/HTTPD/Async.pm
+++ b/lib/PublicInbox/HTTPD/Async.pm
@@ -23,6 +23,7 @@ sub new {
$self;
}
+# fires after pending writes are complete:
sub restart_read_cb ($) {
my ($self) = @_;
sub { $self->watch_read(1) }
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 3247cd0..96fbf38 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -86,8 +86,6 @@ sub psgi_return {
$fh->close if $fh; # async-only
};
- # Danga::Socket users, we queue up the read_enable callback to
- # fire after pending writes are complete:
my $buf = '';
my $rd_hdr = sub {
my $r = sysread($rpipe, $buf, 1024, length($buf));
@@ -102,7 +100,7 @@ sub psgi_return {
my $filter = delete $env->{'qspawn.filter'};
if (scalar(@$r) == 3) { # error
if ($async) {
- $async->close; # calls rpipe->close
+ $async->close; # calls rpipe->close and $end
} else {
$rpipe->close;
$end->();
--
EW
next prev parent reply other threads:[~2019-01-27 4:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-27 4:03 [PATCH 00/14] convert solver to use pi-httpd.async Eric Wong
2019-01-27 4:03 ` [PATCH 01/14] httpd/async: remove needless sysread wrapper Eric Wong
2019-01-27 4:03 ` [PATCH 02/14] qspawn: implement psgi_return and use it for githttpbackend Eric Wong
2019-01-27 4:03 ` [PATCH 03/14] qspawn|getlinebody: support streaming filters Eric Wong
2019-01-27 4:03 ` Eric Wong [this message]
2019-01-27 4:03 ` [PATCH 05/14] httpd/async: stop running command if client disconnects Eric Wong
2019-01-27 4:03 ` [PATCH 06/14] qspawn: implement psgi_qx Eric Wong
2019-01-27 4:03 ` [PATCH 07/14] t/qspawn.t: psgi_qx stderr test Eric Wong
2019-01-27 4:03 ` [PATCH 08/14] view: swap CRLF for LF in HTML output Eric Wong
2019-01-27 4:03 ` [PATCH 09/14] solver: rewrite to use Qspawn->psgi_qx and pi-httpd.async Eric Wong
2019-01-27 4:03 ` [PATCH 10/14] solver: hold patches in temporary directory Eric Wong
2019-01-27 4:03 ` [PATCH 11/14] solver: reduce "git apply" invocations Eric Wong
2019-01-27 4:03 ` [PATCH 12/14] qspawn: decode $? for user-friendliness Eric Wong
2019-01-27 4:03 ` [PATCH 13/14] viewvcs: do not show final error message twice Eric Wong
2019-01-27 4:03 ` [PATCH 14/14] solver: crank up max patches to 9999 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190127040341.26107-5-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).