From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 05A5821426 for ; Sun, 27 Jan 2019 04:03:44 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 13/14] viewvcs: do not show final error message twice Date: Sun, 27 Jan 2019 04:03:40 +0000 Message-Id: <20190127040341.26107-14-e@80x24.org> In-Reply-To: <20190127040341.26107-1-e@80x24.org> References: <20190127040341.26107-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: SolverGit::ERR already writes the exception to the debug log before calling {user_cb}, so there's no need for viewvcs to append it. --- lib/PublicInbox/ViewVCS.pm | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index fa76086..5de37ee 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -46,7 +46,6 @@ sub solve_result { $log = do { local $/; <$log> }; my $ref = ref($res); - $log .= $res unless $ref; my $l = PublicInbox::Linkify->new; $l->linkify_1($log); $log = '
debug log:
' .
-- 
EW