From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 3026F2142F for ; Mon, 21 Jan 2019 20:52:58 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 20/37] solver: add a TODO note about making this fully evented Date: Mon, 21 Jan 2019 20:52:36 +0000 Message-Id: <20190121205253.10455-21-e@80x24.org> In-Reply-To: <20190121205253.10455-1-e@80x24.org> References: <20190121205253.10455-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: Applying a 100+ patch series can be a pain and lead to a wayward client monopolizing the connection. On the other hand, we'll also need to be careful and limit the number of in-flight file descriptors and parallel git-apply processes when we move to an evented model, here. --- lib/PublicInbox/SolverGit.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm index 42bb603..1306534 100644 --- a/lib/PublicInbox/SolverGit.pm +++ b/lib/PublicInbox/SolverGit.pm @@ -358,6 +358,9 @@ sub apply_patches_cb ($$$$$) { # recreate $oid_b # Returns an array ref: [ ::Git object, oid_full, type, size, di ] # or undef if nothing was found. +# +# TODO: complete the migration of this and ViewVCS into an evented +# model for fairness sub solve ($$$$) { my ($self, $out, $oid_b, $hints) = @_; -- EW