[PATCH] nntp: header responses use CRLF consistently

[Eric Wong <e@80x24.org>]

Thanks, I'm pretty sure the following will fix it.

Not sure why others hadn't noticed since there's a lot of Alpine
users judging from Message-IDs.  Anyways I managed to replicate it
quickly with alpine in Debian ("alpine -url news://...") and
strace quickly showed me the difference.

Deploying to news.public-inbox.org shortly.
Cc-ing Konstantin for kernel.org.

---------------8<-----------------
Subject: [PATCH] nntp: header responses use CRLF consistently

Alpine is apparently stricter than other clients I've tried
w.r.t. using CRLF for headers.  So do the same thing we do for
bodies to ensure we only emit CRLFs and no bare LFs.

Reported-by: Wang Kang <i@scateu.me>
  https://public-inbox.org/meta/alpine.DEB.2.21.99.1901161043430.29788@la.scateu.me/
---
 lib/PublicInbox/NNTP.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 623ffd3..63d5870 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -515,6 +515,7 @@ sub set_art {
 sub _header ($) {
 	my $hdr = $_[0]->header_obj->as_string;
 	utf8::encode($hdr);
+	$hdr =~ s/(?<!\r)\n/\r\n/sg;
 	$hdr
 }
 
-- 
EW