unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/6] t/cgi.t: test speedups and cleanups
Date: Fri,  4 Jan 2019 13:10:32 +0000	[thread overview]
Message-ID: <20190104131038.32233-1-e@80x24.org> (raw)

While we relied on CGI.pm early in the project, we've moved onto PSGI
and relied on PSGI for providing CGI compatibility.  Thus, most of our
CGI-based tests are redundant and Perl startup overhead is painful.

On my system, this cuts the t/cgi.t from 4.4s to 1.8s for a nice
improvement.  Moving some tests to t/plack.t did not increase runtimes
in a meaningful way.

Eric Wong (6):
  t/cgi.t: eliminate some cruft and unnecessary tests
  t/cgi.t: remove redundant redirect check
  t/cgi.t: remove atom.xml test
  t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t
  t/cgi.t: move expected failure tests to t/plack.t
  t/cgi.t: remove more redundant tests

 t/cgi.t   | 105 ++++++++----------------------------------------------
 t/plack.t |  43 ++++++++++++++++++++--
 2 files changed, 54 insertions(+), 94 deletions(-)

-- 
EW

             reply	other threads:[~2019-01-04 13:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-04 13:10 Eric Wong [this message]
2019-01-04 13:10 ` [PATCH 1/6] t/cgi.t: eliminate some cruft and unnecessary tests Eric Wong
2019-01-04 13:10 ` [PATCH 2/6] t/cgi.t: remove redundant redirect check Eric Wong
2019-01-04 13:10 ` [PATCH 3/6] t/cgi.t: remove atom.xml test Eric Wong
2019-01-04 13:10 ` [PATCH 4/6] t/cgi.t: move dumb HTTP git clone/fetch tests to plack.t Eric Wong
2019-01-04 13:10 ` [PATCH 5/6] t/cgi.t: move expected failure tests to t/plack.t Eric Wong
2019-01-04 13:10 ` [PATCH 6/6] t/cgi.t: remove more redundant tests Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190104131038.32233-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).