unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/2] t/git.t: reorder IPC::Run check
Date: Sat, 29 Dec 2018 05:51:14 +0000	[thread overview]
Message-ID: <20181229055114.4mccxh7bmmkekynu@dcvr> (raw)
In-Reply-To: <20181229034722.16949-2-e@80x24.org>

We can't skip tests after "use_ok"
---
 t/git.t | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/git.t b/t/git.t
index 5069ae2..6538b6c 100644
--- a/t/git.t
+++ b/t/git.t
@@ -8,8 +8,8 @@ my $dir = tempdir('pi-git-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 use Cwd qw/getcwd/;
 use PublicInbox::Spawn qw(popen_rd);
 
-use_ok 'PublicInbox::Git';
 eval { require IPC::Run } or plan skip_all => 'IPC::Run missing';
+use_ok 'PublicInbox::Git';
 
 {
 	is(system(qw(git init -q --bare), $dir), 0, 'created git directory');
-- 
EW

  reply	other threads:[~2018-12-29  5:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29  3:47 [PATCH 0/2] test cleanups Eric Wong
2018-12-29  3:47 ` [PATCH 1/2] tests: consolidate process spawning code Eric Wong
2018-12-29  5:51   ` Eric Wong [this message]
2018-12-29  3:47 ` [PATCH 2/2] t/cgi.t: shorten %ENV setting Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181229055114.4mccxh7bmmkekynu@dcvr \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).