From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 9BD421F453; Tue, 16 Oct 2018 04:04:36 +0000 (UTC) Date: Tue, 16 Oct 2018 04:04:36 +0000 From: Eric Wong To: Jonathan Corbet Cc: meta@public-inbox.org Subject: Re: [PATCH v2 0/2] Make NNTP Xrefs work better Message-ID: <20181016040436.GA13957@dcvr> References: <20181013214221.7568-1-corbet@lwn.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181013214221.7568-1-corbet@lwn.net> List-Id: Jonathan Corbet wrote: > I finally found some time to figure out why the Xref changes weren't having > the desired effect for me; the result is the following two changes. > > As always, these patches are likely to reveal that I really haven't done > any perl in decades and that I'm still kind of groping my way around the > public-inbox source. Hopefully they aren't too bad... No worries, Perl (or anything else) feels rusty to me after only a few days/weeks away :x > Version 2 makes the tests work and improves the setting of the server name. Thanks! Applied and pushed to https://public-inbox.org/ as commit fbfd63996ddfc9a23b8a1e0f8756e378f2e196ba > Jonathan Corbet (2): > Put the NNTP server name into Xref lines > Add Xrefs to over/xover lines I was concerned about exposing the NNTP server hostname for people running Tor onions, but having "publicinbox.nntpserver" already-configured on my mirror onions means no changes were needed on my end. Other onion operators (if they exist) may need to take notice. I haven't deployed to news.public-inbox.org / ou63pmih66umazou.onion, yet; but both nntp://hjrcffqmbrq6wope.onion/ and nntp://czquwvybam4bgbro.onion/ are running the new code.