From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.1 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 95FBB208E8; Sun, 15 Jul 2018 03:18:23 +0000 (UTC) Date: Sun, 15 Jul 2018 03:18:23 +0000 From: Eric Wong To: "Eric W. Biederman" Cc: meta@public-inbox.org Subject: Re: msgmap serial number regeneration [was: Q: V2 format] Message-ID: <20180715031823.GA24609@dcvr> References: <87k1q1bky6.fsf@xmission.com> <20180712014715.dn5aouayoa3uejp4@dcvr> <87k1q07dyc.fsf@xmission.com> <20180712230946.mqv3yjw4aabf7xrf@dcvr.yhbt.net> <878t6f1ch7.fsf@xmission.com> <87h8l2ykb4.fsf@xmission.com> <20180713222200.GB27845@dcvr> <87a7qtwsih.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a7qtwsih.fsf@xmission.com> List-Id: "Eric W. Biederman" wrote: > I believe we can modify the msg number assignment to assign numbers to > deletes as well as adds. Short of the same Message-ID coming up twice > that should be enough for the current backwards loop to assign message > ids reliably. And even Message-IDs comming up twice is handle-able. OK, I would likely accept a patch to fix that. A note about Message-ID uniqueness... The v2 code will generate a new, truly unique Message-ID on duplicates and use that in msgmap instead what was in the message. It's gross, but I needed to do that to allow all messages to be accessible via Message-ID over NNTP, because: a) some legit messages reuse Message-IDs :< b) some broken mailers (including some versions of git-send-email) put multiple Message-IDs in the same message, so the code needs to handle messages with any number of Message-IDs anyways.