unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: [PATCH] Contribute SELinux policy for EL7
Date: Wed, 30 May 2018 03:15:24 +0000	[thread overview]
Message-ID: <20180530031524.GA28636@dcvr> (raw)
In-Reply-To: <20180524190306.GA23233@work>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> This adds a SELinux policy suitable for RHEL/CentOS 7. It assumes the
> following:

I'm not familiar with SELinux myself, but I'm inclined to accept
a version of this if it helps people who use it.

Some questions, below...

> - public-inbox-httpd and public-inbox-nntpd are running via systemd
>  on sane ports (119 and 80/8080)
> - /var/lib/public-inbox is the location for mainrepos
> - /var/run/public-inbox is the location for PERL_INLINE_DIRECTORY
> - /var/log/public-inbox is the location for logs
> - mail delivery is done via postfix-pipe (if you're using
>  public-inbox-watch, you shouldn't need to worry about this)

So nothing is needed for public-inbox-watch at all?

> --- /dev/null
> +++ b/contrib/selinux/el7/publicinbox.fc
> @@ -0,0 +1,7 @@
> +/usr/(local/)?bin/public-inbox-httpd    -- gen_context(system_u:object_r:publicinbox_daemon_exec_t,s0)
> +/usr/(local/)?bin/public-inbox-nntpd    -- gen_context(system_u:object_r:publicinbox_daemon_exec_t,s0)
> +/usr/(local/)?bin/public-inbox-mda      -- gen_context(system_u:object_r:publicinbox_deliver_exec_t,s0)

Is it possible to use "\" or similar to wrap long lines?

(same comments applies to the .te file; I need to use a gigantic font)

<snip>

> --- /dev/null
> +++ b/contrib/selinux/el7/publicinbox.te
> @@ -0,0 +1,101 @@
> +##################
> +# This policy allows running public-inbox-httpd and public-inbox-nntpd
> +# on reasonable ports (119 for nntpd and 80/443/8080 for httpd)
> +#
> +# It also allows delivering mail via postfix-pipe to public-inbox-mda
> +#
> +# Author: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
> +#
> +policy_module(publicinbox, 1.0.0)

Is that 1.0.0 tied to public-inbox versions itself or
independent of public-inbox versioning?

> +# Need to be able to manage and exec runtime files for inline::c

correct capitalization should be: "Inline::C"

<snip>

> +# Run on http/httpcache and innd ports

innd?

  reply	other threads:[~2018-05-30  3:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-24 19:03 [PATCH] Contribute SELinux policy for EL7 Konstantin Ryabitsev
2018-05-30  3:15 ` Eric Wong [this message]
2018-05-30 17:13   ` Konstantin Ryabitsev
2018-05-30 20:25     ` Eric Wong
2018-06-15 19:11 ` [PATCH v2] " Konstantin Ryabitsev
2018-06-16  8:06   ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530031524.GA28636@dcvr \
    --to=e@80x24.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).