From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 2ACB31F406;
	Thu, 10 May 2018 21:51:20 +0000 (UTC)
Date: Thu, 10 May 2018 21:51:19 +0000
From: Eric Wong <e@80x24.org>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: meta@public-inbox.org
Subject: Re: Failed tests on CentOS-7
Message-ID: <20180510215119.GA19307@dcvr>
References: <5486bce6-811b-d762-ad23-07be918f2d8a@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5486bce6-811b-d762-ad23-07be918f2d8a@linuxfoundation.org>
List-Id: <meta.public-inbox.org>

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> Hello:
> 
> Running "make test" I get the following failures:
> 
> t/content_id.t ......... 1/?
> #   Failed test 'content_id does not mutate From:'
> #   at t/content_id.t line 29.
> #          got: '"Quoted N'Ame" <foo@EXAMPLE.com>'
> #     expected: '"Quoted N\'Ame" <foo@EXAMPLE.com>'

> Anything I can do to help troubleshoot this? The modules were installed
> from CPAN per the INSTALL file.

Which versions of perl, Email::MIME, Email::MIME::Encodings, and
Email::Simple are you running?

Does s/header_str_set/header_set/ work around the problem?
(if so, I think it might be E::M::Encodings...)

The following should improve the readability of the failure
messages, I got the order of is() args backwards and q() can be
more readable in source than ''.

--- a/t/content_id.t
+++ b/t/content_id.t
@@ -23,10 +23,10 @@ my $reload = content_id(Email::MIME->new($mime->as_string));
 is($orig, $reload, 'content_id matches after serialization');
 
 foreach my $h (qw(From To Cc)) {
-	my $n = '"Quoted N\'Ame" <foo@EXAMPLE.com>';
+	my $n = q("Quoted N'Ame" <foo@EXAMPLE.com>);
 	$mime->header_str_set($h, "$n");
 	my $q = content_id($mime);
-	is($n, $mime->header($h), "content_id does not mutate $h:");
+	is($mime->header($h), $n, "content_id does not mutate $h:");
 	$mime->header_str_set($h, 'Quoted N\'Ame <foo@example.com>');
 	my $nq = content_id($mime);
 	is($nq, $q, "quotes ignored in $h:");