unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* Failed tests on CentOS-7
@ 2018-05-10 21:12 Konstantin Ryabitsev
  2018-05-10 21:51 ` Eric Wong
  0 siblings, 1 reply; 3+ messages in thread
From: Konstantin Ryabitsev @ 2018-05-10 21:12 UTC (permalink / raw)
  To: meta


[-- Attachment #1.1: Type: text/plain, Size: 908 bytes --]

Hello:

Running "make test" I get the following failures:

t/content_id.t ......... 1/?
#   Failed test 'content_id does not mutate From:'
#   at t/content_id.t line 29.
#          got: '"Quoted N'Ame" <foo@EXAMPLE.com>'
#     expected: '"Quoted N\'Ame" <foo@EXAMPLE.com>'

#   Failed test 'content_id does not mutate To:'
#   at t/content_id.t line 29.
#          got: '"Quoted N'Ame" <foo@EXAMPLE.com>'
#     expected: '"Quoted N\'Ame" <foo@EXAMPLE.com>'

#   Failed test 'content_id does not mutate Cc:'
#   at t/content_id.t line 29.
#          got: '"Quoted N'Ame" <foo@EXAMPLE.com>'
#     expected: '"Quoted N\'Ame" <foo@EXAMPLE.com>'
# Looks like you failed 3 tests of 7.

Anything I can do to help troubleshoot this? The modules were installed
from CPAN per the INSTALL file.

Regards,
-- 
Konstantin Ryabitsev
Director, IT Infrastructure Security
The Linux Foundation


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Failed tests on CentOS-7
  2018-05-10 21:12 Failed tests on CentOS-7 Konstantin Ryabitsev
@ 2018-05-10 21:51 ` Eric Wong
  2018-05-11 15:45   ` Konstantin Ryabitsev
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Wong @ 2018-05-10 21:51 UTC (permalink / raw)
  To: Konstantin Ryabitsev; +Cc: meta

Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> Hello:
> 
> Running "make test" I get the following failures:
> 
> t/content_id.t ......... 1/?
> #   Failed test 'content_id does not mutate From:'
> #   at t/content_id.t line 29.
> #          got: '"Quoted N'Ame" <foo@EXAMPLE.com>'
> #     expected: '"Quoted N\'Ame" <foo@EXAMPLE.com>'

> Anything I can do to help troubleshoot this? The modules were installed
> from CPAN per the INSTALL file.

Which versions of perl, Email::MIME, Email::MIME::Encodings, and
Email::Simple are you running?

Does s/header_str_set/header_set/ work around the problem?
(if so, I think it might be E::M::Encodings...)

The following should improve the readability of the failure
messages, I got the order of is() args backwards and q() can be
more readable in source than ''.

--- a/t/content_id.t
+++ b/t/content_id.t
@@ -23,10 +23,10 @@ my $reload = content_id(Email::MIME->new($mime->as_string));
 is($orig, $reload, 'content_id matches after serialization');
 
 foreach my $h (qw(From To Cc)) {
-	my $n = '"Quoted N\'Ame" <foo@EXAMPLE.com>';
+	my $n = q("Quoted N'Ame" <foo@EXAMPLE.com>);
 	$mime->header_str_set($h, "$n");
 	my $q = content_id($mime);
-	is($n, $mime->header($h), "content_id does not mutate $h:");
+	is($mime->header($h), $n, "content_id does not mutate $h:");
 	$mime->header_str_set($h, 'Quoted N\'Ame <foo@example.com>');
 	my $nq = content_id($mime);
 	is($nq, $q, "quotes ignored in $h:");

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Failed tests on CentOS-7
  2018-05-10 21:51 ` Eric Wong
@ 2018-05-11 15:45   ` Konstantin Ryabitsev
  0 siblings, 0 replies; 3+ messages in thread
From: Konstantin Ryabitsev @ 2018-05-11 15:45 UTC (permalink / raw)
  To: Eric Wong; +Cc: meta


[-- Attachment #1.1.1: Type: text/plain, Size: 1321 bytes --]

On 05/10/18 17:51, Eric Wong wrote:
> Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
>> Hello:
>>
>> Running "make test" I get the following failures:
>>
>> t/content_id.t ......... 1/?
>> #   Failed test 'content_id does not mutate From:'
>> #   at t/content_id.t line 29.
>> #          got: '"Quoted N'Ame" <foo@EXAMPLE.com>'
>> #     expected: '"Quoted N\'Ame" <foo@EXAMPLE.com>'
> 
>> Anything I can do to help troubleshoot this? The modules were installed
>> from CPAN per the INSTALL file.
> 
> Which versions of perl, Email::MIME, Email::MIME::Encodings, and
> Email::Simple are you running?

# cpanm --info Email::MIME
RJBS/Email-MIME-1.946.tar.gz
# cpanm --info Email::MIME::Encodings
RJBS/Email-MIME-Encodings-1.315.tar.gz
# cpanm --info Email::Simple
RJBS/Email-Simple-2.214.tar.gz
# perl --version

This is perl 5, version 16, subversion 3 (v5.16.3) built for
x86_64-linux-thread-multi
(with 33 registered patches, see perl -V for more detail)

> 
> Does s/header_str_set/header_set/ work around the problem?
> (if so, I think it might be E::M::Encodings...)

Yes, that fixes that test.

There are two more test failures besides this one -- see attached output.

Best,
-- 
Konstantin Ryabitsev
Director, IT Infrastructure Security
The Linux Foundation

[-- Attachment #1.1.2: public-inbox-test.txt --]
[-- Type: text/plain, Size: 3154 bytes --]

# make test
PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t
t/address.t ............ ok
t/altid.t .............. ok
t/altid_v2.t ........... ok
t/cgi.t ................ ok
t/config.t ............. ok
t/config_limiter.t ..... ok
t/content_id.t ......... ok
t/convert-compact.t .... 1/? public-inbox-compact /tmp/convert-compact-LXS_qS/v1 failed: 32768
# Tests were run but no plan was declared and done_testing() was not seen.
t/convert-compact.t .... Dubious, test returned 254 (wstat 65024, 0xfe00)
All 25 subtests passed
t/emergency.t .......... ok
t/feed.t ............... ok
t/filter_base.t ........ ok
t/filter_mirror.t ...... ok
t/filter_rubylang.t .... ok
t/filter_subjecttag.t .. ok
t/filter_vger.t ........ ok
t/git-http-backend.t ... skipped: GIANT_GIT_DIR not defined
t/git.t ................ ok
t/html_index.t ......... ok
t/httpd-corner.t ....... ok
t/httpd-unix.t ......... ok
t/httpd.t .............. ok
t/hval.t ............... ok
t/import.t ............. ok
t/inbox.t .............. ok
t/init.t ............... ok
t/linkify.t ............ ok
t/mda.t ................ ok
t/mid.t ................ ok
t/mime.t ............... ok
t/msg_iter.t ........... ok
t/msgmap.t ............. ok
t/nntp.t ............... ok
t/nntpd.t .............. ok
t/over.t ............... ok
t/perf-nntpd.t ......... skipped: GIANT_PI_DIR not defined for t/perf-nntpd.t
t/perf-threading.t ..... skipped: GIANT_PI_DIR not defined for t/perf-threading.t
t/plack.t .............. ok
t/precheck.t ........... ok
t/psgi_attach.t ........ ok
t/psgi_mount.t ......... ok
t/psgi_search.t ........ ok
t/psgi_text.t .......... ok
t/psgi_v2.t ............ ok
t/qspawn.t ............. ok
t/reply.t .............. ok
t/search-thr-index.t ... ok
t/search.t ............. 1/? Argument contains empty address at /usr/local/share/perl5/Email/MIME/Encode.pm line 70.
t/search.t ............. ok
t/spamcheck_spamc.t .... ok
t/spawn.t .............. ok
t/thread-cycle.t ....... ok
t/time.t ............... ok
t/v1-add-remove-add.t .. ok
t/v2-add-remove-add.t .. ok
t/v2mda.t .............. ok
t/v2mirror.t ........... 18/? Exception: Unable to get write lock on /tmp/pi-v2mirror-2dJVii/in/xap15/0: already locked# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 11 just after 30.
t/v2mirror.t ........... Dubious, test returned 11 (wstat 2816, 0xb00)
All 30 subtests passed
t/v2reindex.t .......... ok
t/v2writable.t ......... ok
t/view.t ............... ok
t/watch_maildir.t ...... ok
t/watch_maildir_v2.t ... ok

Test Summary Report
-------------------
t/convert-compact.t  (Wstat: 65024 Tests: 25 Failed: 0)
  Non-zero exit status: 254
  Parse errors: No plan found in TAP output
t/v2mirror.t         (Wstat: 2816 Tests: 30 Failed: 0)
  Non-zero exit status: 11
  Parse errors: No plan found in TAP output
Files=60, Tests=1370, 32 wallclock secs ( 0.31 usr  0.06 sys + 18.48 cusr  5.51 csys = 24.36 CPU)
Result: FAIL
Failed 2/60 test programs. 0/1370 subtests failed.
make: *** [test_dynamic] Error 255


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-05-11 15:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-10 21:12 Failed tests on CentOS-7 Konstantin Ryabitsev
2018-05-10 21:51 ` Eric Wong
2018-05-11 15:45   ` Konstantin Ryabitsev

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).