* [PATCH] search: avoid repeated mbox results from search
@ 2018-04-23 5:06 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2018-04-23 5:06 UTC (permalink / raw)
To: meta
Previous search queries already set sort order on the Enquire
object, altering the ordering of results and was causing
messages to be redundantly downloaded via POST /$INBOX/?q=$QUERY&x=m
So stop caching the Search::Xapian::Enquire object since it
wasn't providing any measurable performance improvement.
---
lib/PublicInbox/Search.pm | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/lib/PublicInbox/Search.pm b/lib/PublicInbox/Search.pm
index 5aabda0..69eca9f 100644
--- a/lib/PublicInbox/Search.pm
+++ b/lib/PublicInbox/Search.pm
@@ -219,14 +219,13 @@ sub _do_enquire {
sub _enquire_once {
my ($self, $query, $opts) = @_;
- my $enquire = enquire($self);
+ my $enquire = Search::Xapian::Enquire->new($self->{xdb});
$enquire->set_query($query);
$opts ||= {};
my $desc = !$opts->{asc};
if (($opts->{mset} || 0) == 2) {
$enquire->set_docid_order(Search::Xapian::ENQ_ASCENDING());
$enquire->set_weighting_scheme(Search::Xapian::BoolWeight->new);
- delete $self->{enquire};
} elsif ($opts->{relevance}) {
$enquire->set_sort_by_relevance_then_value(TS, $desc);
} else {
@@ -334,11 +333,6 @@ sub subject_normalized {
$subj;
}
-sub enquire {
- my ($self) = @_;
- $self->{enquire} ||= Search::Xapian::Enquire->new($self->{xdb});
-}
-
sub help {
my ($self) = @_;
$self->qp; # parse altids
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-23 5:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-23 5:06 [PATCH] search: avoid repeated mbox results from search Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).