From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS37560 197.231.220.0/22 X-Spam-Status: No, score=-3.3 required=3.0 tests=AWL,BAYES_00,RCVD_IN_XBL, SPF_FAIL,SPF_HELO_FAIL shortcircuit=no autolearn=no autolearn_force=no version=3.4.0 Received: from 80x24.org (exit1.ipredator.se [197.231.221.211]) by dcvr.yhbt.net (Postfix) with ESMTP id 4AB671FAE2 for ; Fri, 30 Mar 2018 20:53:47 +0000 (UTC) From: "Eric Wong (Contractor, The Linux Foundation)" To: meta@public-inbox.org Subject: [PATCH 1/4] convert: avoid redundant "done\n" statement for fast-import Date: Fri, 30 Mar 2018 20:53:34 +0000 Message-Id: <20180330205337.19025-2-e@80x24.org> In-Reply-To: <20180330205337.19025-1-e@80x24.org> References: <20180330205337.19025-1-e@80x24.org> List-Id: This bug was hidden due to timing problems with eatmydata or running with tmpfs for TMPDIR. --- script/public-inbox-convert | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/script/public-inbox-convert b/script/public-inbox-convert index 2b0a385..e6fb4f5 100755 --- a/script/public-inbox-convert +++ b/script/public-inbox-convert @@ -91,9 +91,8 @@ while (<$rd>) { $from = $1; # no next } - } elsif ($_ eq "done\n") { - last; } + last if $_ eq "done\n"; $w->print($_) or $im->wfail; } $w = $r = undef; -- EW