From: "Eric Wong (Contractor, The Linux Foundation)" <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/4] convert: avoid redundant "done\n" statement for fast-import
Date: Fri, 30 Mar 2018 20:53:34 +0000 [thread overview]
Message-ID: <20180330205337.19025-2-e@80x24.org> (raw)
In-Reply-To: <20180330205337.19025-1-e@80x24.org>
This bug was hidden due to timing problems with eatmydata or
running with tmpfs for TMPDIR.
---
script/public-inbox-convert | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/script/public-inbox-convert b/script/public-inbox-convert
index 2b0a385..e6fb4f5 100755
--- a/script/public-inbox-convert
+++ b/script/public-inbox-convert
@@ -91,9 +91,8 @@ while (<$rd>) {
$from = $1;
# no next
}
- } elsif ($_ eq "done\n") {
- last;
}
+ last if $_ eq "done\n";
$w->print($_) or $im->wfail;
}
$w = $r = undef;
--
EW
next prev parent reply other threads:[~2018-03-30 20:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-30 20:53 [PATCH 0/4] v2 permissions Eric Wong (Contractor, The Linux Foundation)
2018-03-30 20:53 ` Eric Wong (Contractor, The Linux Foundation) [this message]
2018-03-30 20:53 ` [PATCH 2/4] search: move permissions handling to InboxWritable Eric Wong (Contractor, The Linux Foundation)
2018-03-30 20:53 ` [PATCH 3/4] t/v2writable: use simplify permissions reading Eric Wong (Contractor, The Linux Foundation)
2018-03-30 20:53 ` [PATCH 4/4] v2: respect core.sharedRepository in git configs Eric Wong (Contractor, The Linux Foundation)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330205337.19025-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).