From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] view: s/threaded/nested/ in view
Date: Thu, 19 Oct 2017 07:18:03 +0000 [thread overview]
Message-ID: <20171019071803.14159-1-e@80x24.org> (raw)
We always do threading, so perhaps it's not a good name.
"Nested" is probably more appropriate and closer to what
people are used to seeing.
---
lib/PublicInbox/View.pm | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index ac7657a..ad94977 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -186,17 +186,17 @@ sub index_entry {
$rv .= "\t[relevance $pct->{$mid_raw}%]";
$hr = 1;
} elsif ($mapping) {
- my $threaded = 'threaded';
+ my $nested = 'nested';
my $flat = 'flat';
my $end = '';
if ($ctx->{flat}) {
$hr = 1;
$flat = "<b>$flat</b>";
} else {
- $threaded = "<b>$threaded</b>";
+ $nested = "<b>$nested</b>";
}
$rv .= "\t[<a\nhref=\"${mhref}T/#u\">$flat</a>";
- $rv .= "|<a\nhref=\"${mhref}t/#u\">$threaded</a>]";
+ $rv .= "|<a\nhref=\"${mhref}t/#u\">$nested</a>]";
$rv .= " <a\nhref=#r$id>$ctx->{s_nr}</a>";
} else {
$hr = $ctx->{-hr};
--
EW
next reply other threads:[~2017-10-19 7:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 7:18 Eric Wong [this message]
2017-11-29 9:27 ` [PATCH] searchview: s/threaded/nested/ Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019071803.14159-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).