* [PATCH] www: do not unescape PATH_INFO twice
@ 2017-02-14 22:46 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2017-02-14 22:46 UTC (permalink / raw)
To: meta
PSGI specs already require PATH_INFO to be unescaped;
so our tests were wrong, too.
---
lib/PublicInbox/WWW.pm | 2 +-
t/cgi.t | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 430e6b1..62e4ca4 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -165,7 +165,7 @@ sub invalid_inbox_mid {
my $ret = invalid_inbox($ctx, $inbox);
return $ret if $ret;
- $ctx->{mid} = $mid = uri_unescape($mid);
+ $ctx->{mid} = $mid;
if ($mid =~ /\A[a-f0-9]{40}\z/) {
# this is horiffically wasteful for legacy URLs:
if ($mid = mid2blob($ctx)) {
diff --git a/t/cgi.t b/t/cgi.t
index 092ad8c..7740966 100644
--- a/t/cgi.t
+++ b/t/cgi.t
@@ -148,7 +148,7 @@ EOF
$im->add($reply);
$im->done;
- my $res = cgi_run("/test/slashy%2fasdf\@example.com/raw");
+ my $res = cgi_run("/test/slashy/asdf\@example.com/raw");
like($res->{body}, qr/Message-Id: <\Q$slashy_mid\E>/,
"slashy mid raw hit");
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-02-14 22:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-14 22:46 [PATCH] www: do not unescape PATH_INFO twice Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).