From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/9] qspawn: prepare to support runtime reloading of Limiter
Date: Sat, 7 Jan 2017 01:44:44 +0000 [thread overview]
Message-ID: <20170107014452.9657-2-e@80x24.org> (raw)
In-Reply-To: <20170107014452.9657-1-e@80x24.org>
We may allow the {max} value of a limiter to be changed
in the future, so lets start accounting for it before we
spawn followup processes.
---
lib/PublicInbox/Qspawn.pm | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 697c55a..4950da2 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -31,14 +31,19 @@ sub _do_spawn {
sub finish ($) {
my ($self) = @_;
my $limiter = $self->{limiter};
+ my $running;
if (delete $self->{rpipe}) {
my $pid = delete $self->{pid};
$self->{err} = $pid == waitpid($pid, 0) ? $? :
"PID:$pid still running?";
- $limiter->{running}--;
+ $running = --$limiter->{running};
}
- if (my $next = shift @{$limiter->{run_queue}}) {
- _do_spawn(@$next);
+
+ # limiter->{max} may change dynamically
+ if (($running || $limiter->{running}) < $limiter->{max}) {
+ if (my $next = shift @{$limiter->{run_queue}}) {
+ _do_spawn(@$next);
+ }
}
$self->{err};
}
--
EW
next prev parent reply other threads:[~2017-01-07 1:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-07 1:44 [PATCH 0/9] misc cleanups and trimming Eric Wong
2017-01-07 1:44 ` Eric Wong [this message]
2017-01-07 1:44 ` [PATCH 2/9] config: always use namespaced "publicinboxlimiter" Eric Wong
2017-01-07 1:44 ` [PATCH 3/9] config: remove unused get() method Eric Wong
2017-01-07 1:44 ` [PATCH 4/9] inbox: describe the full key name Eric Wong
2017-01-07 1:44 ` [PATCH 5/9] inbox: eliminate weaken usage entirely Eric Wong
2017-01-07 2:12 ` [PATCH 10/9] inbox: properly register cleanup timer for git processes Eric Wong
2017-01-11 10:21 ` [PATCH 11/9] inbox: reinstate periodic cleanup of Xapian and SQLite objects Eric Wong
2017-01-07 1:44 ` [PATCH 6/9] config: allow per-inbox nntpserver Eric Wong
2017-01-07 1:44 ` [PATCH 7/9] remove incorrect comment about strftime + locales Eric Wong
2017-01-07 1:44 ` [PATCH 8/9] searchmsg: favor direct hash access over accessor methods Eric Wong
2017-01-07 1:44 ` [PATCH 9/9] search: remove subject_summary Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170107014452.9657-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).