From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 4/4] httpd/async: improve variable naming
Date: Sun, 25 Dec 2016 10:36:53 +0000 [thread overview]
Message-ID: <20161225103653.8325-5-e@80x24.org> (raw)
In-Reply-To: <20161225103653.8325-1-e@80x24.org>
We only refer to PublicInbox::HTTP objects here, so '$io'
was a bad name.
---
lib/PublicInbox/HTTPD/Async.pm | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/lib/PublicInbox/HTTPD/Async.pm b/lib/PublicInbox/HTTPD/Async.pm
index 68514f5..79951ca 100644
--- a/lib/PublicInbox/HTTPD/Async.pm
+++ b/lib/PublicInbox/HTTPD/Async.pm
@@ -30,10 +30,10 @@ sub restart_read_cb ($) {
}
sub async_pass {
- my ($self, $io, $fh, $bref) = @_;
- # In case the client HTTP connection ($io) dies, it
+ my ($self, $http, $fh, $bref) = @_;
+ # In case the client HTTP connection ($http) dies, it
# will automatically close this ($self) object.
- $io->{forward} = $self;
+ $http->{forward} = $self;
$fh->write($$bref);
my $restart_read = restart_read_cb($self);
weaken($self);
@@ -41,10 +41,10 @@ sub async_pass {
my $r = sysread($self->{sock}, $$bref, 8192);
if ($r) {
$fh->write($$bref);
- return if $io->{closed};
- if ($io->{write_buf_size}) {
+ return if $http->{closed};
+ if ($http->{write_buf_size}) {
$self->watch_read(0);
- $io->write($restart_read); # D::S::write
+ $http->write($restart_read); # D::S::write
}
# stay in watch_read, but let other clients
# get some work done, too.
@@ -55,7 +55,7 @@ sub async_pass {
# Done! Error handling will happen in $fh->close
# called by the {cleanup} handler
- $io->{forward} = undef;
+ $http->{forward} = undef;
$self->close;
}
}
--
EW
prev parent reply other threads:[~2016-12-25 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 10:36 [PATCH 0/4] various cleanups around http Eric Wong
2016-12-25 10:36 ` [PATCH 1/4] githttpbackend: minor readability improvement Eric Wong
2016-12-25 10:36 ` [PATCH 2/4] githttpbackend: simplify compatibility code Eric Wong
2016-12-25 10:36 ` [PATCH 3/4] githttpbackend: minor cleanups to improve readability Eric Wong
2016-12-25 10:36 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161225103653.8325-5-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).