From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 0/2] searchthread: minor cleanups and API change
Date: Wed, 21 Dec 2016 07:36:05 +0000 [thread overview]
Message-ID: <20161221073607.32236-1-e@80x24.org> (raw)
Couldn't find more ways to speed things up, but it's looking
pretty good. walk_thread could probably be moved into SearchThread.pm
(from View.pm), though
I also read enough of the Perl5 source code to learn
"scalar keys %hash" and "scalar values %hash"
follow the same code path and is optimized to not generate
an intermediate array :)
Eric Wong (2):
searchthread: update comment about loop prevention
searchthread: simplify API and remove needless OO
lib/PublicInbox/SearchThread.pm | 39 ++++++++++++++-------------------------
lib/PublicInbox/SearchView.pm | 25 ++++++++++++-------------
lib/PublicInbox/View.pm | 19 ++++++++-----------
t/thread-cycle.t | 8 ++++----
4 files changed, 38 insertions(+), 53 deletions(-)
next reply other threads:[~2016-12-21 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 7:36 Eric Wong [this message]
2016-12-21 7:36 ` [PATCH 1/2] searchthread: update comment about loop prevention Eric Wong
2016-12-21 7:36 ` [PATCH 2/2] searchthread: simplify API and remove needless OO Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221073607.32236-1-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).