From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id B3FBC2018E;
	Fri,  5 Aug 2016 11:09:24 +0000 (UTC)
Date: Fri, 5 Aug 2016 11:09:24 +0000
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: Re: [PATCH 2/2] search: support reindexing existing search indices
Message-ID: <20160805110924.GA10142@starla>
References: <20160802011815.10728-1-e@80x24.org>
 <20160802011815.10728-3-e@80x24.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20160802011815.10728-3-e@80x24.org>
List-Id: <meta@public-inbox.org>

Eric Wong <e@80x24.org> wrote:
> +	my $cb = sub {
> +		my ($commit, $more) = @_;
> +		$xdb->set_metadata($mkey, $commit) if $mkey && $commit;
> +		if ($dbh) {
> +			$mm->last_commit($commit) if $commit;
> +			$dbh->commit;
> +		}
> +		_xdb_release($self);
> +		# let another process do some work...
> +		$dbh->begin_work if $dbh && $more;

Bleh, this release/acquire breaks newer versions of Xapian
(tested from Debian jessie-backports and sid) since the FD
flintlock doesn't have O_CLOEXEC set and "git log" is still
running at this point and holding the F_OFD_SETLK and friends.

Might be a bug to fix in Xapian...

> +		$xdb = _xdb_acquire($self);
> +	};