unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH] learn: fix uninitialized variable
Date: Tue, 26 Jul 2016 01:00:49 +0000	[thread overview]
Message-ID: <20160726010049.18876-1-e@80x24.org> (raw)

Oops :x
---
 script/public-inbox-learn | 2 +-
 t/mda.t                   | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/script/public-inbox-learn b/script/public-inbox-learn
index 09fd7c8..396ab48 100755
--- a/script/public-inbox-learn
+++ b/script/public-inbox-learn
@@ -57,7 +57,7 @@ foreach my $recipient (keys %dests) {
 	my $git = PublicInbox::Git->new($git_dir);
 	# We do not touch GIT_COMMITTER_* env here so we can track
 	# who trained the message.
-	my $name = $ENV{GIT_COMMITTER_NAME} || $dst->{inbox};
+	my $name = $ENV{GIT_COMMITTER_NAME} || $dst->{name};
 	my $email = $ENV{GIT_COMMITTER_EMAIL} || $recipient;
 	my $im = PublicInbox::Import->new($git, $name, $email);
 
diff --git a/t/mda.t b/t/mda.t
index 32154bd..886b4cb 100644
--- a/t/mda.t
+++ b/t/mda.t
@@ -187,6 +187,7 @@ EOF
 		# now train it
 		local $ENV{GIT_AUTHOR_EMAIL} = 'trainer@example.com';
 		local $ENV{GIT_COMMITTER_EMAIL} = 'trainer@example.com';
+		local $ENV{GIT_COMMITTER_NAME} = undef;
 		IPC::Run::run([$learn, "spam"], \$msg);
 		is($?, 0, "no failure from learning spam");
 		IPC::Run::run([$learn, "spam"], \$msg);
-- 
EW


                 reply	other threads:[~2016-07-26  1:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726010049.18876-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).