From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 3/6] feed: remove dead code and unneeded use
Date: Sat, 9 Jul 2016 03:18:32 +0000 [thread overview]
Message-ID: <20160709031835.21005-4-e@80x24.org> (raw)
In-Reply-To: <20160709031835.21005-1-e@80x24.org>
We've cleaned up our code in recent days and WwwStream
provides a consistent header for our HTML pages.
---
lib/PublicInbox/Feed.pm | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm
index 3b0ae42..a697a43 100644
--- a/lib/PublicInbox/Feed.pm
+++ b/lib/PublicInbox/Feed.pm
@@ -8,7 +8,6 @@ use warnings;
use Email::MIME;
use Date::Parse qw(strptime);
use PublicInbox::Hval qw/ascii_html/;
-use PublicInbox::Git;
use PublicInbox::View;
use PublicInbox::MID qw/mid_clean mid2path/;
use PublicInbox::Address;
@@ -150,27 +149,6 @@ sub emit_atom_thread {
end_feed($fh);
}
-sub _html_index_top {
- my ($feed_opts, $srch) = @_;
-
- my $title = ascii_html($feed_opts->{description} || '');
- my $top = "<b>$title</b> (<a\nhref=\"new.atom\">Atom feed</a>)";
- if ($srch) {
- $top = qq{<form\naction=""><pre>$top} .
- qq{ <input\nname=q\ntype=text />} .
- qq{<input\ntype=submit\nvalue=search />} .
- q{</pre></form><pre>}
- } else {
- $top = '<pre>' . $top . "\n";
- }
-
- "<html><head><title>$title</title>" .
- "<link\nrel=alternate\ntitle=\"Atom feed\"\n".
- "href=\"new.atom\"\ntype=\"application/atom+xml\"/>" .
- PublicInbox::Hval::STYLE .
- "</head><body>$top";
-}
-
sub new_html_footer {
my ($ctx, $last) = @_;
my $qp = delete $ctx->{qp} or return;
--
EW
next prev parent reply other threads:[~2016-07-09 3:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 3:18 [PATCH 0/6] bunch of cleanups and a new feature! Eric Wong
2016-07-09 3:18 ` [PATCH 1/6] www: drop unused constants Eric Wong
2016-07-09 3:18 ` [PATCH 2/6] www: cleanup parameter passing Eric Wong
2016-07-09 3:18 ` Eric Wong [this message]
2016-07-09 3:18 ` [PATCH 4/6] cleanup some unnecessary use/requires Eric Wong
2016-07-09 3:18 ` [PATCH 5/6] qspawn: allow configurable limiters Eric Wong
2016-07-09 3:18 ` [PATCH 6/6] www: add " Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160709031835.21005-4-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).