From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] view: reduce visual noise in conversation view
Date: Thu, 7 Jul 2016 03:11:28 +0000 [thread overview]
Message-ID: <20160707031130.4634-2-e@80x24.org> (raw)
In-Reply-To: <20160707031130.4634-1-e@80x24.org>
No need for ' / ' delimiters on lines dedicated for hyperlinks.
---
lib/PublicInbox/View.pm | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 0903550..7be72cf 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -156,10 +156,10 @@ sub index_entry {
# add the footer
$rv .= "\n<a\nhref=#$id_m\nid=e$id>^</a> ".
"<a\nhref=\"$mhref\">permalink</a>" .
- " / <a\nhref=\"${mhref}raw\">raw</a>" .
- " / <a\nhref=\"${mhref}#R\">reply</a>";
+ " <a\nhref=\"${mhref}raw\">raw</a>" .
+ " <a\nhref=\"${mhref}#R\">reply</a>";
if (my $pct = $ctx->{pct}) { # used by SearchView.pm
- $rv .= " [relevance $pct->{$mid_raw}%]";
+ $rv .= "\t[relevance $pct->{$mid_raw}%]";
} elsif ($mapping) {
my $threaded = 'threaded';
my $flat = 'flat';
@@ -169,9 +169,9 @@ sub index_entry {
} else {
$threaded = "<b>$threaded</b>";
}
- $rv .= " / [<a\nhref=\"${mhref}T/#u\">$flat</a>";
+ $rv .= "\t[<a\nhref=\"${mhref}T/#u\">$flat</a>";
$rv .= "|<a\nhref=\"${mhref}t/#u\">$threaded</a>]";
- $rv .= " / <a\nhref=#r$id>$ctx->{s_nr}</a>";
+ $rv .= " <a\nhref=#r$id>$ctx->{s_nr}</a>";
}
$rv .= $more ? "\n\n" : "\n";
--
EW
next prev parent reply other threads:[~2016-07-07 3:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 3:11 [PATCH 0/3] view: visual and navigation tweaks Eric Wong
2016-07-07 3:11 ` Eric Wong [this message]
2016-07-07 3:11 ` [PATCH 2/3] view: preserve attribution for current message Eric Wong
2016-07-07 3:11 ` [PATCH 3/3] view: per-message view links to real previous sibling Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707031130.4634-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).