From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 02/10] daemon: disable USR2/TTIN/TTOU/WINCH in workers
Date: Wed, 6 Jul 2016 07:14:27 +0000 [thread overview]
Message-ID: <20160706071435.18143-3-e@80x24.org> (raw)
In-Reply-To: <20160706071435.18143-1-e@80x24.org>
If using a master/worker setup, a careless user could be trying
to signal all processes using "killall". This may trigger bad
side-effects; but try to limit the side-effects as much as
possible.
---
lib/PublicInbox/Daemon.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm
index 512bb20..7849f9c 100644
--- a/lib/PublicInbox/Daemon.pm
+++ b/lib/PublicInbox/Daemon.pm
@@ -449,7 +449,8 @@ sub daemon_loop ($$) {
$SIG{QUIT} = $SIG{INT} = $SIG{TERM} = *worker_quit;
$SIG{USR1} = *reopen_logs;
$SIG{HUP} = $refresh;
- $SIG{$_} = 'DEFAULT' for qw(CHLD USR2 TTIN TTOU WINCH);
+ $SIG{CHLD} = 'DEFAULT';
+ $SIG{$_} = 'IGNORE' for qw(USR2 TTIN TTOU WINCH);
# this calls epoll_create:
@listeners = map {
PublicInbox::Listener->new($_, $post_accept)
--
EW
next prev parent reply other threads:[~2016-07-06 7:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 7:14 [PATCH 0/10] various misc fixes and updates Eric Wong
2016-07-06 7:14 ` [PATCH 01/10] scripts/dc-dlvr: ensure temporary files are removed Eric Wong
2016-07-06 7:14 ` Eric Wong [this message]
2016-07-06 7:14 ` [PATCH 03/10] hval: get rid of unused parameter for new_msgid Eric Wong
2016-07-06 7:14 ` [PATCH 04/10] address: attempt to handle comments somewhat Eric Wong
2016-07-06 7:14 ` [PATCH 05/10] wwwstream: allow undef noop callback Eric Wong
2016-07-06 7:14 ` [PATCH 06/10] extmsg: disable automatic inbox switching Eric Wong
2016-07-06 7:14 ` [PATCH 07/10] extmsg: switch to wwwstream for partial match, too Eric Wong
2016-07-06 7:14 ` [PATCH 08/10] view: fix double-escaping of ghost links Eric Wong
2016-07-06 7:14 ` [PATCH 09/10] www: use HTML <hr> instead of XHTML <hr /> Eric Wong
2016-07-06 7:14 ` [PATCH 10/10] feed: fix links to attachments in Atom feed Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706071435.18143-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).