From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 5/6] view: rely on internal query parser for 'o' param
Date: Sat, 2 Jul 2016 07:56:37 +0000 [thread overview]
Message-ID: <20160702075638.31017-6-e@80x24.org> (raw)
In-Reply-To: <20160702075638.31017-1-e@80x24.org>
Plack::Request will check the request body by merely
calling "param", totally unnecessary and sneaky.
---
lib/PublicInbox/View.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index fd882aa..1527959 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -908,7 +908,7 @@ sub emit_topics {
sub emit_index_topics {
my ($ctx) = @_;
- my ($off) = (($ctx->{cgi}->param('o') || '0') =~ /(\d+)/);
+ my ($off) = (($ctx->{qp}->{o} || '0') =~ /(\d+)/);
$ctx->{order} = [];
$ctx->{subjs} = {};
$ctx->{latest} = {};
--
EW
next prev parent reply other threads:[~2016-07-02 7:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 7:56 [PATCH 0/6] misc cleanups Eric Wong
2016-07-02 7:56 ` [PATCH 1/6] TODO: clarify streaming Email::MIME replacement Eric Wong
2016-07-02 7:56 ` [PATCH 2/6] inbox: base_url method takes PSGI env hashref instead Eric Wong
2016-07-02 7:56 ` [PATCH 3/6] extmsg: rework to use Inbox objects Eric Wong
2016-07-02 7:56 ` [PATCH 4/6] www: use PSGI env directly Eric Wong
2016-07-02 7:56 ` Eric Wong [this message]
2016-07-02 7:56 ` [PATCH 6/6] www: remove Plack::Request dependency entirely Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160702075638.31017-6-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).