From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id CA6F02018A
	for <meta@public-inbox.org>; Thu, 30 Jun 2016 09:58:36 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/2] view: improve readability of msg_reply with here-doc
Date: Thu, 30 Jun 2016 09:58:33 +0000
Message-Id: <20160630095834.2723-2-e@80x24.org>
In-Reply-To: <20160630095834.2723-1-e@80x24.org>
References: <20160630095834.2723-1-e@80x24.org>
List-Id: <meta@public-inbox.org>

This should make formatting more apparent since we can rely
on <pre> semantics.
---
 lib/PublicInbox/View.pm | 36 ++++++++++++++++++++++--------------
 1 file changed, 22 insertions(+), 14 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 27dd155..9d48dfc 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -54,21 +54,29 @@ sub msg_reply {
 
 	my ($arg, $link) = mailto_arg_link($hdr);
 	push @$arg, '/path/to/YOUR_REPLY';
+	$arg = join(" \\\n    ", '', @$arg);
+	<<EOF
+<pre
+id=R>You may reply publically to <a
+href=#t>this message</a> via
+plain-text email using any one of the following methods:
 
-	"<pre\nid=R>".
-	"You may reply publically to <a\nhref=#t>this message</a> via\n".
-	"plain-text email using any one of the following methods:\n\n" .
-	"* Save the following mbox file, import it into your mail client,\n" .
-	"  and reply-to-all from there: <a\nhref=raw>mbox</a>\n\n" .
-	"* Reply to all the recipients using the <b>--to</b>, <b>--cc</b>,\n" .
-	"  and <b>--in-reply-to</b> switches of git-send-email(1):\n\n" .
-	"  git send-email \\\n    " .
-	join(" \\\n    ", @$arg ). "\n\n" .
-	qq(  <a\nhref="$se_url">$se_url</a>\n\n) .
-	"* If your mail client supports setting the <b>In-Reply-To</b>" .
-	" header\n  via mailto: links, try the " .
-	qq(<a\nhref="$link">mailto: link</a>\n) .
-	'</pre>';
+* Save the following mbox file, import it into your mail client,
+  and reply-to-all from there: <a
+href=raw>mbox</a>
+
+* Reply to all the recipients using the <b>--to</b>, <b>--cc</b>,
+  and <b>--in-reply-to</b> switches of git-send-email(1):
+
+  git send-email$arg
+
+  <a
+href="$se_url">$se_url</a>
+
+* If your mail client supports setting the <b>In-Reply-To</b> header
+  via mailto: links, try the <a
+href="$link">mailto: link</a></pre>
+EOF
 }
 
 sub in_reply_to {
-- 
EW