From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00
	shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 2563F1FF40
	for <meta@public-inbox.org>; Tue, 21 Jun 2016 03:12:03 +0000 (UTC)
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/7] view: remove upfx parameter from thread skeleton dump
Date: Tue, 21 Jun 2016 03:11:55 +0000
Message-Id: <20160621031201.28089-2-e@80x24.org>
In-Reply-To: <20160621031201.28089-1-e@80x24.org>
References: <20160621031201.28089-1-e@80x24.org>
List-Id: <meta@public-inbox.org>

This makes the string creation somewhat simpler hopefully
makes the code easier-to-reason with.
---
 lib/PublicInbox/View.pm | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index dfae44f..9095c50 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -383,9 +383,10 @@ sub thread_skel {
 		cur => $mid,
 		prev_attr => '',
 		prev_level => 0,
+		upfx => "$tpfx../",
 	};
 	for (thread_results(load_results($sres))->rootset) {
-		skel_dump($dst, $state, $tpfx, $_, 0);
+		skel_dump($dst, $state, $_, 0);
 	}
 	$ctx->{next_msg} = $state->{next_msg};
 	$ctx->{parent_msg} = $parent;
@@ -663,7 +664,7 @@ sub _msg_date {
 sub fmt_ts { POSIX::strftime('%Y-%m-%d %k:%M', gmtime($_[0])) }
 
 sub _skel_header {
-	my ($dst, $state, $upfx, $hdr, $level) = @_;
+	my ($dst, $state, $hdr, $level) = @_;
 
 	my $cur = $state->{cur};
 	my $mid = mid_clean($hdr->header_raw('Message-ID'));
@@ -705,18 +706,18 @@ sub _skel_header {
 		$s = $s->as_html;
 	}
 	my $m = PublicInbox::Hval->new_msgid($mid);
-	$m = $upfx . '../' . $m->as_href . '/';
+	$m = $state->{upfx} . $m->as_href . '/';
 	$$dst .= "$pfx<a\nhref=\"$m\">";
 	$$dst .= defined($s) ? "$s</a> $f\n" : "$f</a>\n";
 }
 
 sub skel_dump {
-	my ($dst, $state, $upfx, $node, $level) = @_;
+	my ($dst, $state, $node, $level) = @_;
 	return unless $node;
 	if (my $mime = $node->message) {
 		my $hdr = $mime->header_obj;
 		my $mid = mid_clean($hdr->header_raw('Message-ID'));
-		_skel_header($dst, $state, $upfx, $hdr, $level);
+		_skel_header($dst, $state, $hdr, $level);
 	} else {
 		my $mid = $node->messageid;
 		if ($mid eq 'subject dummy') {
@@ -725,13 +726,13 @@ sub skel_dump {
 			$$dst .= '     [not found] ';
 			$$dst .= indent_for($level) . th_pfx($level);
 			$mid = PublicInbox::Hval->new_msgid($mid);
-			my $href = "$upfx../" . $mid->as_href . '/';
+			my $href = $state->{upfx} . $mid->as_href . '/';
 			my $html = $mid->as_html;
 			$$dst .= qq{&lt;<a\nhref="$href">$html</a>&gt;\n};
 		}
 	}
-	skel_dump($dst, $state, $upfx, $node->child, $level+1);
-	skel_dump($dst, $state, $upfx, $node->next, $level);
+	skel_dump($dst, $state, $node->child, $level+1);
+	skel_dump($dst, $state, $node->next, $level);
 }
 
 sub sort_ts {