From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.0 required=3.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED shortcircuit=no autolearn=unavailable autolearn_force=no version=3.4.0 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 2F3751FCD0 for ; Sat, 28 May 2016 01:57:19 +0000 (UTC) From: Eric Wong To: meta@public-inbox.org Subject: [PATCH 5/7] www: remove footer_html support Date: Sat, 28 May 2016 01:57:12 +0000 Message-Id: <20160528015714.1325-6-e@80x24.org> In-Reply-To: <20160528015714.1325-1-e@80x24.org> References: <20160528015714.1325-1-e@80x24.org> List-Id: I haven't used it in a while and the existing "description" is probably good enough. If we support it again, it should be plain-text + auto-linkified for ease-of-maintenance and consistency. --- lib/PublicInbox/Inbox.pm | 10 ---------- lib/PublicInbox/WWW.pm | 2 -- 2 files changed, 12 deletions(-) diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm index 4bcab96..c07aaa9 100644 --- a/lib/PublicInbox/Inbox.pm +++ b/lib/PublicInbox/Inbox.pm @@ -64,16 +64,6 @@ sub cloneurl { $self->{cloneurl} = \@url; } -# TODO: can we remove this? -sub footer_html { - my ($self) = @_; - my $footer = $self->{footer}; - return $footer if defined $footer; - $footer = try_cat("$self->{mainrepo}/public-inbox/footer.html"); - chomp $footer; - $self->{footer} = $footer; -} - sub base_url { my ($self, $prq) = @_; # Plack::Request if (defined $prq) { diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm index 5b4d6c1..e8f1fbf 100644 --- a/lib/PublicInbox/WWW.pm +++ b/lib/PublicInbox/WWW.pm @@ -252,8 +252,6 @@ sub footer { my ($ctx) = @_; return '' unless $ctx; my $obj = $ctx->{-inbox} or return ''; - my $footer = $obj->footer_html; - return $ctx->{footer} = $footer if $footer; # auto-generate a footer chomp(my $desc = $obj->description); -- EW