unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/7] http: clarify comments about layering violation
Date: Sat, 28 May 2016 01:57:09 +0000	[thread overview]
Message-ID: <20160528015714.1325-3-e@80x24.org> (raw)
In-Reply-To: <20160528015714.1325-1-e@80x24.org>

It's a low priority, but acknowledge it.
---
 lib/PublicInbox/HTTP.pm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/HTTP.pm b/lib/PublicInbox/HTTP.pm
index 0454f60..fcbd758 100644
--- a/lib/PublicInbox/HTTP.pm
+++ b/lib/PublicInbox/HTTP.pm
@@ -4,7 +4,7 @@
 # Generic PSGI server for convenience.  It aims to provide
 # a consistent experience for public-inbox admins so they don't have
 # to learn different ways to admin both NNTP and HTTP components.
-# There's nothing public-inbox-specific, here.
+# There's nothing which depends on public-inbox, here.
 # Each instance of this class represents a HTTP client socket
 
 package PublicInbox::HTTP;
@@ -25,7 +25,7 @@ use constant {
 	CHUNK_MAX_HDR => 256,
 };
 
-# FIXME: duplicated code with NNTP.pm
+# FIXME: duplicated code with NNTP.pm, layering violation
 my $WEAKEN = {}; # string(inbox) -> inbox
 my $weakt;
 sub weaken_task () {
@@ -249,6 +249,8 @@ sub response_done ($$) {
 	$self->{env} = undef;
 	$self->write("0\r\n\r\n") if $alive == 2;
 	$self->write(sub { $alive ? next_request($self) : $self->close });
+
+	# FIXME: layering violation
 	if (my $obj = $env->{'pi-httpd.inbox'}) {
 		# grace period for reaping resources
 		$WEAKEN->{"$obj"} = $obj;
-- 
EW


  parent reply	other threads:[~2016-05-28  1:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-28  1:57 [PATCH 0/7] miscellaneous cleanups Eric Wong
2016-05-28  1:57 ` [PATCH 1/7] t/plack: ensure we can cascade on common endpoints Eric Wong
2016-05-28  1:57 ` Eric Wong [this message]
2016-05-28  1:57 ` [PATCH 3/7] Makefile.PL: allow N to be overridden Eric Wong
2016-05-28  1:57 ` [PATCH 4/7] examples: config no longer supports atomUrl Eric Wong
2016-05-28  1:57 ` [PATCH 5/7] www: remove footer_html support Eric Wong
2016-05-28  1:57 ` [PATCH 6/7] config: remove try_cat Eric Wong
2016-05-28  1:57 ` [PATCH 7/7] remove redundant NewsGroup class Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160528015714.1325-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).