* [PATCH] daemon: ignore SIGWINCH when connected to terminal
@ 2016-05-23 1:02 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-05-23 1:02 UTC (permalink / raw)
To: meta
Users may change terminal sizes if the process is connected to a
terminal, so we can't reasonably expect SIGWINCH to work as
intended.
---
lib/PublicInbox/Daemon.pm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Daemon.pm b/lib/PublicInbox/Daemon.pm
index 3d895b0..b64ec87 100644
--- a/lib/PublicInbox/Daemon.pm
+++ b/lib/PublicInbox/Daemon.pm
@@ -375,7 +375,13 @@ sub master_loop {
exit if $quit++;
kill_workers($s);
} elsif ($s eq 'WINCH') {
- $worker_processes = 0;
+ if (-t STDIN || -t STDOUT || -t STDERR) {
+ warn
+"ignoring SIGWINCH while connected to terminal\n";
+ $SIG{WINCH} = 'IGNORE';
+ } else {
+ $worker_processes = 0;
+ }
} elsif ($s eq 'HUP') {
$worker_processes = $set_workers;
kill_workers($s);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-05-23 1:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-23 1:02 [PATCH] daemon: ignore SIGWINCH when connected to terminal Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).