* [PATCH] git-http-backend: use real lseek for Content-Range
@ 2016-05-01 22:18 Eric Wong
0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-05-01 22:18 UTC (permalink / raw)
To: meta
Since we use sysread, we must use sysseek for symmetry although
PerlIO may be doing a real lseek with "seek", anyways.
Fixes: 310819ea86ac ("git-http-backend: favor sysread for regular files")
---
lib/PublicInbox/GitHTTPBackend.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 5863462..5169e97 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -178,7 +178,7 @@ sub prepare_range {
if ($len <= 0) {
$code = 416;
} else {
- seek($in, $beg, SEEK_SET) or return [ 500, [], [] ];
+ sysseek($in, $beg, SEEK_SET) or return [ 500, [], [] ];
push @$h, qw(Accept-Ranges bytes Content-Range);
push @$h, "bytes $beg-$end/$size";
--
EW
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-05-01 22:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-01 22:18 [PATCH] git-http-backend: use real lseek for Content-Range Eric Wong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).