unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] view: show flat thread view in chronological order
@ 2016-04-16 18:51 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-04-16 18:51 UTC (permalink / raw)
  To: meta

Allowing readers new to a topic to follow in chronological order
probably makes the most sense.  Reverse chronological order may
reduce scrolling (e.g. log view); but nearly all non-threaded
conversation displays seem to be chronological so perhaps
there's a good reason for that.
---
 lib/PublicInbox/View.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index f07979e..36df7ea 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -174,10 +174,10 @@ sub thread_html {
 sub emit_thread_html {
 	my ($res, $ctx, $foot, $srch) = @_;
 	my $mid = $ctx->{mid};
-	my $msgs = load_results($srch->get_thread($mid));
+	my $flat = $ctx->{flat};
+	my $msgs = load_results($srch->get_thread($mid, { asc => $flat }));
 	my $nr = scalar @$msgs;
 	return missing_thread($res, $ctx) if $nr == 0;
-	my $flat = $ctx->{flat};
 	my $seen = {};
 	my $state = {
 		res => $res,
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-16 18:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-16 18:51 [PATCH] view: show flat thread view in chronological order Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).