unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
* [PATCH] mbox: unconditionally add trailing newline
@ 2016-04-11  5:07 Eric Wong
  0 siblings, 0 replies; only message in thread
From: Eric Wong @ 2016-04-11  5:07 UTC (permalink / raw)
  To: meta

This may be necessary for compatibility with non-mboxrd aware
parsers which expect "\nFrom " for everything but the first
record.
---
 lib/PublicInbox/Mbox.pm | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm
index 0d67981..9f20580 100644
--- a/lib/PublicInbox/Mbox.pm
+++ b/lib/PublicInbox/Mbox.pm
@@ -67,9 +67,7 @@ sub emit_msg {
 	# ref: http://www.qmail.org/man/man5/mbox.html
 	$buf =~ s/^(>*From )/>$1/gm;
 
-	$buf .= "\n" unless $buf =~ /\n\z/s;
-
-	$fh->write($buf);
+	$fh->write($buf .= "\n");
 }
 
 sub emit_mbox {
-- 
EW


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-04-11  5:07 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-11  5:07 [PATCH] mbox: unconditionally add trailing newline Eric Wong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).