From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] httpd: document pi-httpd.async as totally unstable
Date: Tue, 1 Mar 2016 08:31:43 +0000 [thread overview]
Message-ID: <20160301083145.26125-2-e@80x24.org> (raw)
In-Reply-To: <20160301083145.26125-1-e@80x24.org>
We'll have to use it some more before deciding it is a public
interface. I do hope for it to be a usable public interface
one day for other users.
---
lib/PublicInbox/GitHTTPBackend.pm | 2 +-
script/public-inbox-httpd | 4 ++++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/lib/PublicInbox/GitHTTPBackend.pm b/lib/PublicInbox/GitHTTPBackend.pm
index 56bf24f..c84eefc 100644
--- a/lib/PublicInbox/GitHTTPBackend.pm
+++ b/lib/PublicInbox/GitHTTPBackend.pm
@@ -224,7 +224,7 @@ sub serve_smart {
if (my $async = $env->{'pi-httpd.async'}) {
$rpipe = $async->($rpipe, $cb);
sub { ($res) = @_ } # let Danga::Socket handle the rest.
- } else { # synchronous loop
+ } else { # synchronous loop for other PSGI servers
$vin = '';
vec($vin, fileno($rpipe), 1) = 1;
sub {
diff --git a/script/public-inbox-httpd b/script/public-inbox-httpd
index f1a5d79..d407059 100755
--- a/script/public-inbox-httpd
+++ b/script/public-inbox-httpd
@@ -59,6 +59,10 @@ daemon_run('0.0.0.0:8080', $refresh,
1;
+# XXX This is a totally unstable API for public-inbox internal use only
+# This is exposed via the 'pi-httpd.async' key in the PSGI env hash.
+# The name of this key is not even stable!
+# Currently is is intended for use with read-only pipes.
package PublicInbox::HTTPD::Async;
use strict;
use warnings;
--
EW
next prev parent reply other threads:[~2016-03-01 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 8:31 [PATCH 0/3] minor httpd related tweaks Eric Wong
2016-03-01 8:31 ` Eric Wong [this message]
2016-03-01 8:31 ` [PATCH 2/3] httpd: remove unneeded err and out fields from class Eric Wong
2016-03-01 8:31 ` [PATCH 3/3] http: better error handling for EMFILE/ENFILE Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160301083145.26125-2-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).