From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/3] searchidx: use defined for checking EOF behavior
Date: Sun, 28 Feb 2016 11:28:32 +0000 [thread overview]
Message-ID: <20160228112833.11319-3-e@80x24.org> (raw)
In-Reply-To: <20160228112833.11319-1-e@80x24.org>
While empty or "0" should never appear, this allows the
reviewer to think and know less about the context in which
this check is done.
---
lib/PublicInbox/SearchIdx.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm
index 6727299..1d0d926 100644
--- a/lib/PublicInbox/SearchIdx.pm
+++ b/lib/PublicInbox/SearchIdx.pm
@@ -337,7 +337,7 @@ sub rlog {
--raw -r --no-abbrev/, $range);
my $latest;
my $bytes;
- while (my $line = <$log>) {
+ while (defined(my $line = <$log>)) {
if ($line =~ /$addmsg/o) {
my $mime = do_cat_mail($git, $1, \$bytes) or next;
$add_cb->($self, $git, $mime, $bytes);
--
EW
next prev parent reply other threads:[~2016-02-28 11:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-28 11:28 [PATCH 0/3] another round of minor updates Eric Wong
2016-02-28 11:28 ` [PATCH 1/3] t/: remove unnecessary Dumper use Eric Wong
2016-02-28 11:28 ` Eric Wong [this message]
2016-02-28 11:28 ` [PATCH 3/3] reduce calls to close unless error checks are needed Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://public-inbox.org/README
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160228112833.11319-3-e@80x24.org \
--to=e@80x24.org \
--cc=meta@public-inbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).