unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 1/3] t/: remove unnecessary Dumper use
Date: Sun, 28 Feb 2016 11:28:31 +0000	[thread overview]
Message-ID: <20160228112833.11319-2-e@80x24.org> (raw)
In-Reply-To: <20160228112833.11319-1-e@80x24.org>

No point in loading Data::Dumper if we do not use it
in the tests.
---
 t/nntpd.t  | 1 -
 t/search.t | 1 -
 2 files changed, 2 deletions(-)

diff --git a/t/nntpd.t b/t/nntpd.t
index f6f71a2..d8c2e7b 100644
--- a/t/nntpd.t
+++ b/t/nntpd.t
@@ -17,7 +17,6 @@ use Socket qw(SO_KEEPALIVE IPPROTO_TCP TCP_NODELAY);
 use File::Temp qw/tempdir/;
 use Net::NNTP;
 use IPC::Run qw(run);
-use Data::Dumper;
 
 my $tmpdir = tempdir(CLEANUP => 1);
 my $home = "$tmpdir/pi-home";
diff --git a/t/search.t b/t/search.t
index cd7048f..3ec3f30 100644
--- a/t/search.t
+++ b/t/search.t
@@ -7,7 +7,6 @@ eval { require PublicInbox::SearchIdx; };
 plan skip_all => "Xapian missing for search" if $@;
 use File::Temp qw/tempdir/;
 use Email::MIME;
-use Data::Dumper;
 my $tmpdir = tempdir(CLEANUP => 1);
 my $git_dir = "$tmpdir/a.git";
 my ($root_id, $last_id);
-- 
EW


  reply	other threads:[~2016-02-28 11:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28 11:28 [PATCH 0/3] another round of minor updates Eric Wong
2016-02-28 11:28 ` Eric Wong [this message]
2016-02-28 11:28 ` [PATCH 2/3] searchidx: use defined for checking EOF behavior Eric Wong
2016-02-28 11:28 ` [PATCH 3/3] reduce calls to close unless error checks are needed Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160228112833.11319-2-e@80x24.org \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).