unofficial mirror of meta@public-inbox.org
 help / color / mirror / Atom feed
From: Eric Wong <e@80x24.org>
To: meta@public-inbox.org
Subject: [PATCH 2/1] spawn: fail properly if Inline fails
Date: Sat, 27 Feb 2016 22:19:10 +0000	[thread overview]
Message-ID: <20160227221910.GA2020@dcvr.yhbt.net> (raw)
In-Reply-To: <20160227110045.GA5350@dcvr.yhbt.net>

We must stash the error correctly when nesting evals, oops :x
---
 lib/PublicInbox/Spawn.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 394a0b4..72cd6c3 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -111,7 +111,9 @@ if (defined $vfork_spawn) {
 		open my $fh, '>', $f or die "failed to open $f: $!\n";
 		flock($fh, LOCK_EX) or die "LOCK_EX failed on $f: $!\n";
 		eval 'use Inline C => $vfork_spawn';
+		my $err = $@;
 		flock($fh, LOCK_UN) or die "LOCK_UN failed on $f: $!\n";
+		die $err if $err;
 	};
 	if ($@) {
 		warn "Inline::C failed for vfork: $@\n";
-- 
EW


      reply	other threads:[~2016-02-27 22:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-27  2:14 [PATCH] initial spawn implementation using vfork Eric Wong
2016-02-27 11:00 ` [PATCH v2] " Eric Wong
2016-02-27 22:19   ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://public-inbox.org/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160227221910.GA2020@dcvr.yhbt.net \
    --to=e@80x24.org \
    --cc=meta@public-inbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).